[Differential] [Updated] D3548: Add begin/end insert/remove columns to RearrangeColumns

[dfaure (David Faure)]

dfaure added a comment.


  Can you add a unittest too? This class is fully unittested in krearrangecolumnsproxymodeltest.cpp, it's just that changing the source columns configuration "at runtime" wasn't supported. Just add one more test method, with spies for the signals you emit.
  
  Thanks!

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D3548

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: lepagevalleeemmanuel, #frameworks, dfaure
Cc: kfunk, ltoscano
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161229/4ae3a4e7/attachment.html>