Review Request 129713: Only try to open the file if it's not empty

Aleix Pol Gonzalez aleixpol at kde.org
Wed Dec 28 15:02:26 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129713/
-----------------------------------------------------------

Review request for KDE Frameworks and Jeremy Whiting.


Repository: knewstuff


Description
-------

The filename will (always?) be empty, this would end up in an error such as `QFSFileEngine::open: No file name specified`.
This patch prevents the code path.


Diffs
-----

  src/core/security.cpp e9f3ee0 

Diff: https://git.reviewboard.kde.org/r/129713/diff/


Testing
-------


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161228/90a88d74/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list