Review Request 129658: KConfigDialogManager: cleanup static maps

[Albert Astals Cid]

> On Dec. 27, 2016, 9:16 p.m., Albert Astals Cid wrote:
> > -1 Don't break what is not broken.
> > 
> > First thing i check "KButtonGroup", is already wrong to be removed.
> 
> Elvis Angelaccio wrote:
>     Why? Isn't it deprecated? https://api.kde.org/frameworks/kdelibs4support/html/classKButtonGroup.html
> 
> Elvis Angelaccio wrote:
>     Ah wait, I see it now: a kf5 app could be using KConfigDialogManager from KF5 and KButtonGroup from kdelibs4support at the same time..
> 
> Anthony Fieroni wrote:
>     Maybe you should keep all deprecated classes hardcoded.
> 
> Elvis Angelaccio wrote:
>     Yeah.
>     @Albert: it's ok for you if I only remove the kdelibs3 class names? If you want I can also split this patch in 2 commits (one for the QMetaObject conversion and another one for the kdelibs3 cleanup).

having two patches is a much easier way to be able to review them i'd say.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129658/#review101610
-----------------------------------------------------------


On Dec. 16, 2016, 3:05 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129658/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2016, 3:05 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> -------
> 
> The static maps s_changedMaps() and s_propertyMap() still contain a bunch of old class names (even from kdelibs3 times!). This patch replaces most of the hardcoded class names with `QMetaObject::className()`, to ensure compile-time checks and that we don't use non-kf5 classes. We keep the hardcoded names only for widgets in frameworks we don't depen on (KCompletion, KTextWidgets, KIO).
> 
> 
> Diffs
> -----
> 
>   src/kconfigdialogmanager.h 4660805ed12d97c2f9c87fdd247ed46f96fd4f22 
>   src/kconfigdialogmanager.cpp 118d502f2290aa25bf07c1c9dad359fc2b163eaa 
> 
> Diff: https://git.reviewboard.kde.org/r/129658/diff/
> 
> 
> Testing
> -------
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161227/2e2a7163/attachment.html>