Review Request 129658: KConfigDialogManager: cleanup static maps

Elvis Angelaccio elvis.angelaccio at kde.org
Tue Dec 27 21:34:40 UTC 2016



> On Dec. 27, 2016, 9:18 p.m., Christoph Feck wrote:
> > className() is just a char pointer. Is it possible to convert the maps to not use QString?

I don't think so, they are public api, e.g. `static QHash<QString, QByteArray> *changedMap();`


- Elvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129658/#review101612
-----------------------------------------------------------


On Dec. 16, 2016, 3:05 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129658/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2016, 3:05 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> -------
> 
> The static maps s_changedMaps() and s_propertyMap() still contain a bunch of old class names (even from kdelibs3 times!). This patch replaces most of the hardcoded class names with `QMetaObject::className()`, to ensure compile-time checks and that we don't use non-kf5 classes. We keep the hardcoded names only for widgets in frameworks we don't depen on (KCompletion, KTextWidgets, KIO).
> 
> 
> Diffs
> -----
> 
>   src/kconfigdialogmanager.h 4660805ed12d97c2f9c87fdd247ed46f96fd4f22 
>   src/kconfigdialogmanager.cpp 118d502f2290aa25bf07c1c9dad359fc2b163eaa 
> 
> Diff: https://git.reviewboard.kde.org/r/129658/diff/
> 
> 
> Testing
> -------
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161227/222a1bce/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list