Review Request 129709: Fix checking for valid date entered

[David Jarvie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129709/
-----------------------------------------------------------

Review request for KDE Frameworks and John Layt.


Repository: kwidgetsaddons


Description
-------

In two places, the checks to determine whether an entered date is valid is wrong, due to not testing whether a minimum or maximum date is set before comparing to the minimum/maximum date. When a minimum and maximum date is not set, this results in the following bugs currently:
- When an up/down arrow or page up/down key is pressed to change the date, it is always considered invalid and the date is not changed.
- When the DateKeywords option is set, the only date which is displayed for selection is "No Date".

This fixes the checks so that if a minimum date is not set, the date is always treated as complying with the minimum, and the maximum check is similarly fixed.

Documentation comments in the header file are also improved.


Diffs
-----

  src/kdatecombobox.h d9a20ca 
  src/kdatecombobox.cpp ad1d085 

Diff: https://git.reviewboard.kde.org/r/129709/diff/


Testing
-------

Tested with KAlarm, including setting DateKeywords. The bugs described above are now fixed.


Thanks,

David Jarvie

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161227/e2822d6a/attachment.html>