Review Request 129706: Don't focus progress windows

[Martin Tobias Holmedahl Sandsmark]

> On Dec. 26, 2016, 4:24 p.m., Anthony Fieroni wrote:
> > src/kwidgetjobtracker.cpp, line 82
> > <https://git.reviewboard.kde.org/r/129706/diff/1/?file=488130#file488130line82>
> >
> >     You can try
> >     vi->setWindowFlags(windowFlags() | Qt::WindowDoesNotAcceptFocus);
> >     
> >     I didn't know there is input required widget ?

tried it, doesn't work with all WMs (i3 in particular).

in addition the window actually should be able to receive focus, it just shouldn't grab it immediately.


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129706/#review101580
-----------------------------------------------------------


On Dec. 26, 2016, 3:15 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129706/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2016, 3:15 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, David Faure, and Martin Gräßlin.
> 
> 
> Bugs: 333934
>     https://bugs.kde.org/show_bug.cgi?id=333934
> 
> 
> Repository: kjobwidgets
> 
> 
> Description
> -------
> 
> If there is already a window with focus, re-set focus to that so we
>      don't steal focus. This is especially important since there's a 0.5s
>      delay before the window is shown so people often start interacting with
>      the original window when this is shown.
> 
> 
> Diffs
> -----
> 
>   src/kwidgetjobtracker.cpp 585867a 
> 
> Diff: https://git.reviewboard.kde.org/r/129706/diff/
> 
> 
> Testing
> -------
> 
> Job progress widgets don't steal focus anymore.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161227/f3930be1/attachment.html>