Review Request 129666: [KNotificationRestrictions] Let user can specify restriction reason string

Martin Klapetek martin.klapetek at gmail.com
Mon Dec 26 02:48:45 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129666/#review101576
-----------------------------------------------------------




src/knotificationrestrictions.h (line 97)
<https://git.reviewboard.kde.org/r/129666/#comment67998>

    Remove this



src/knotificationrestrictions.cpp (line 82)
<https://git.reviewboard.kde.org/r/129666/#comment67997>

    The coding style, as is elsewhere, is newline after comma


- Martin Klapetek


On Dec. 18, 2016, 9:34 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129666/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2016, 9:34 a.m.)
> 
> 
> Review request for KDE Frameworks and Martin Klapetek.
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> "no_reason_specified" looks annoying reason
> 
> 
> Diffs
> -----
> 
>   src/knotificationrestrictions.h e9179ae 
>   src/knotificationrestrictions.cpp 5f5d908 
> 
> Diff: https://git.reviewboard.kde.org/r/129666/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161226/0cbc07f5/attachment.html>


More information about the Kde-frameworks-devel mailing list