[Differential] [Commented On] D3689: KGlobalAccel: [runtime] Introduce a KGLOBALACCEL_TEST_MODE env variable

graesslin (Martin Gräßlin) noreply at phabricator.kde.org
Thu Dec 22 15:50:58 UTC 2016


graesslin added a comment.


  In https://phabricator.kde.org/D3689#70685, @aacid wrote:
  
  > > We can adjust the shortcuts without having side effects on other tests.
  >
  > Why not just delete the test file on start of each test?
  
  
  I like my tests not affecting other tests. If for whatever reason there is already a kglobalshortcutsrc in the TEST_DATA_DIR I don't think running a kwin  (or kglobalaccel) unit test should delete that file.

REVISION DETAIL
  https://phabricator.kde.org/D3689

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #frameworks
Cc: aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161222/1aba50b4/attachment.html>


More information about the Kde-frameworks-devel mailing list