[Differential] [Request, 7 lines] D3733: Force colored warnings in ninja's output
elvisangelaccio (Elvis Angelaccio)
noreply at phabricator.kde.org
Mon Dec 19 15:39:47 UTC 2016
elvisangelaccio created this revision.
elvisangelaccio added a reviewer: Frameworks.
REVISION SUMMARY
Colored compiler warnings in ninja output only work with the
`-fdiagnostics-color=always` flag.
See https://github.com/ninja-build/ninja/issues/814 for a rationale.
This patch adds such flag in ecm for gcc >= 4.9 and clang >= 3.5;
I'm not sure which version of clang is the first that supports this flag, but it
cannot be < 3.5 because 3.5 was the first release after gcc 4.9.
TEST PLAN
ninja+gcc and ninja+clang now show nice colored compiler warnings.
REPOSITORY
R240 Extra CMake Modules
BRANCH
ninja-colors
REVISION DETAIL
https://phabricator.kde.org/D3733
AFFECTED FILES
kde-modules/KDECompilerSettings.cmake
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: elvisangelaccio, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161219/060dafe3/attachment.html>
More information about the Kde-frameworks-devel
mailing list