Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

[David Faure]

> On Dec. 10, 2016, 4:36 a.m., Anthony Fieroni wrote:
> > filenamesearch/kio_filenamesearch.cpp, line 113
> > <https://git.reviewboard.kde.org/r/129394/diff/2/?file=487091#file487091line113>
> >
> >     Or we must keep KIO::UDSEntry::UDS_URL in new patch ?
> 
> Anthony Fieroni wrote:
>     David, any suggestion? Am i on right way?

I don't know off hand. This needs serious thinking / design with full context in mind, which a RR doesn't really help me with.
We should do an IRC session with Emmanuel, maybe.

We solved similar issues in kio-stash recently, so assuming the purpose is similar in terms of what the user can do with the listed items (which is what I would need a design document or IRC session about), you could try UDS_TARGET_URL instead.
That is the URL that is opened when clicking on the file. It doesn't change the "structural URL", which is the one in the KDirLister tree (on the app side).

What does "view does not contain paths" mean? There is a column with the orig paths?

If I had time I would test and debug this myself, but there are so many other things to debug.... (some of which affect me so they get priority) :(


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129394/#review101351
-----------------------------------------------------------


On Dec. 5, 2016, 8:04 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129394/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2016, 8:04 p.m.)
> 
> 
> Review request for KDE Frameworks, Anthony Fieroni, David Faure, and Emmanuel Pescosta.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> Bug is introduced in https://git.reviewboard.kde.org/r/129297/
> When is fixed new kio-extras realease is needed for 16.08 branch.
> 
> 
> Diffs
> -----
> 
>   filenamesearch/CMakeLists.txt 774d79e 
>   filenamesearch/filenamesearchdbusinterface.h PRE-CREATION 
>   filenamesearch/filenamesearchdbusinterface.cpp PRE-CREATION 
>   filenamesearch/kded/CMakeLists.txt 48160ed 
>   filenamesearch/kded/filenamesearchdbusadaptor.h PRE-CREATION 
>   filenamesearch/kded/filenamesearchdbusadaptor.cpp PRE-CREATION 
>   filenamesearch/kded/filenamesearchmodule.h 4fa6bb1 
>   filenamesearch/kded/filenamesearchmodule.cpp f12626d 
>   filenamesearch/kio_filenamesearch.h 0920394 
>   filenamesearch/kio_filenamesearch.cpp f124f02 
> 
> Diff: https://git.reviewboard.kde.org/r/129394/diff/
> 
> 
> Testing
> -------
> 
> No big ram usage but still not works as expected.
> 1. Perform search in Dolphin
> 2. Delete one result item
> 3. View must be update, but it's not
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161219/42b60143/attachment-0001.html>