Review Request 129665: [KStatusNotifierItem] Restore mnimized window as normal

[Anthony Fieroni]

> On Дек. 18, 2016, 10:51 преди обяд, Martin Gräßlin wrote:
> > src/kstatusnotifieritem.cpp, line 980
> > <https://git.reviewboard.kde.org/r/129665/diff/1/?file=487738#file487738line980>
> >
> >     AFAIK show and showNormal is the same. What is the difference here?
> 
> Anthony Fieroni wrote:
>     The difference is that showNormal restore window state to normal state i.e. not minimized.
>     1. Minimize window (amarok, kmail or any other KDE app who behave in systray)
>     2. Right click in taskmanager -> close
>     3. Click on icon in systray will show app window (showNormal) rather than show it minized (show)
> 
> Martin Gräßlin wrote:
>     If you change from show to showNormal it will also reset states like maximized or fullscreen. From windowing system point that's bad as the state changes. Given that restore as minimized is from windowing system perspective correct. Now I agree that restoring to minimized might not make much sense, but then this needs to be special cased to ensure that maximized state does not get destroyed.

When i make the patch, it think to check that and call showNormal in isMinimized() == true, but i was wonder to see that miximized window is shown correct.


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129665/#review101490
-----------------------------------------------------------


On Дек. 17, 2016, 5:39 след обяд, Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129665/
> -----------------------------------------------------------
> 
> (Updated Дек. 17, 2016, 5:39 след обяд)
> 
> 
> Review request for KDE Frameworks and Martin Gräßlin.
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> I think, we want minized window to be shown as normal when it's closed in tray. Why we could want a window to be shown as minimized ?
> 
> 
> Diffs
> -----
> 
>   src/kstatusnotifieritem.cpp 1cd5e00 
> 
> Diff: https://git.reviewboard.kde.org/r/129665/diff/
> 
> 
> Testing
> -------
> 
> + Remove deprecated warnings
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161218/d203a845/attachment.html>