Review Request 129665: [KStatusNotifierItem] Restore mnimized window as normal

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129665/#review101490
-----------------------------------------------------------




src/kstatusnotifieritem.cpp (line 464)
<https://git.reviewboard.kde.org/r/129665/#comment67935>

    please don't mix coding style changes with other changes.



src/kstatusnotifieritem.cpp (line 979)
<https://git.reviewboard.kde.org/r/129665/#comment67936>

    AFAIK show and showNormal is the same. What is the difference here?


- Martin Gräßlin


On Dec. 17, 2016, 4:39 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129665/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2016, 4:39 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Gräßlin.
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> I think, we want minized window to be shown as normal when it's closed in tray. Why we could want a window to be shown as minimized ?
> 
> 
> Diffs
> -----
> 
>   src/kstatusnotifieritem.cpp 1cd5e00 
> 
> Diff: https://git.reviewboard.kde.org/r/129665/diff/
> 
> 
> Testing
> -------
> 
> + Remove deprecated warnings
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161218/59b01119/attachment.html>