Review Request 129663: Don't break accelerators in KToolBar

Martin Tobias Holmedahl Sandsmark martin.sandsmark at kde.org
Sat Dec 17 12:23:25 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129663/
-----------------------------------------------------------

Review request for KDE Frameworks, David Faure and Chusslove Illich.


Repository: kxmlgui


Description
-------

Don't try to strip out accelerators in the KToolBar event handler. It makes no sense to me, potentially creates an endless repaint loop and fights with KAcceleratorManager which will constantly re-add accelerators.


Diffs
-----

  src/ktoolbar.cpp 31be9b0 

Diff: https://git.reviewboard.kde.org/r/129663/diff/


Testing
-------

With this patch not only the control button in Dolphin has an accelerator.


Thanks,

Martin Tobias Holmedahl Sandsmark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161217/1609b0ac/attachment.html>


More information about the Kde-frameworks-devel mailing list