[Differential] [Commented On] D2075: Fix bug in kfiledialog.cpp that causes crashing when native widgets are used.

[kfunk (Kevin Funk)]

kfunk added a comment.


  In https://phabricator.kde.org/D2075#66751, @jonathans wrote:
  
  > Agreed that would be more robust. In writing the patch I was seeking consistency with those functions that already did the test, so those would also need to be updated. Are there any situations where the two tests would yield a different result, ie d->native is true and d->w is non-null?
  
  
  Probably not. But I think it makes more sense to check the pointer you're actually going to dereference in the next statement.
  
  Could you update the patch? And also fix the `nullptr` issues?

REPOSITORY
  R239  KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D2075

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jonathans, #frameworks, dfaure, kfunk
Cc: kfunk, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161216/ce9f3411/attachment.html>