Review Request 129657: Fix assert (in beginRemoveRows) when deselecting an empty child of a selected child in korganizer

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129657/
-----------------------------------------------------------

(Updated Dec. 16, 2016, 9:23 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Stephen Kelly.


Changes
-------

Submitted with commit 24db696bab2d07388fe124244ce5226f787fd79e by David Faure to branch master.


Repository: kitemmodels


Description
-------

After
   int proxyEndRemove = proxyStartRemove;
   proxyEndRemove += rc; was adding 0 (empty root)
and then --proxyEndRemove; was making us end up with proxyEndRemove < proxyStartRemove.


Diffs
-----

  autotests/kselectionproxymodeltest.cpp 483e7c42dabab6aa560622ff0418ee7f90363e15 
  src/kselectionproxymodel.cpp 0f57c70f05d4cbde9b14f4257bff1365ef5443f6 

Diff: https://git.reviewboard.kde.org/r/129657/diff/


Testing
-------

New unittest + unchecking calendar in korganizer no longer asserts.


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161216/f9839a37/attachment.html>