Review Request 129260: Add find module for QtPlatformSupport

[David Edmundson]

> On Oct. 27, 2016, 5:39 a.m., Martin Gräßlin wrote:
> > Due to https://git.reviewboard.kde.org/r/129268/ I'm giving a -2 to adding to ECM

To this specific patch, or the concept in general?


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129260/#review100323
-----------------------------------------------------------


On Oct. 26, 2016, 9:17 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129260/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2016, 9:17 a.m.)
> 
> 
> Review request for KDE Frameworks, Alex Merry and Martin Gräßlin.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Comes from KWin and will eventually be used in Plasma Integration, hence moving it to extra-cmake-modules.
> 
> 
> Diffs
> -----
> 
>   find-modules/FindQt5PlatformSupport.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129260/diff/
> 
> 
> Testing
> -------
> 
> Removed it from KWin, built KWin, worked.
> 
> Built plasma-integration with QDBusMenu private stuff, worked, although includes there sometimes omit the QtPlatformSupport/ prefix but this is an upstream issue since it works with the files Kwin includes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161215/790c05dd/attachment.html>