Review Request 129613: Revert "If Gpgmepp is not found, try to use KF5Gpgmepp"

David Faure faure at kde.org
Wed Dec 14 23:04:26 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129613/#review101449
-----------------------------------------------------------


Ship it!




Ship It!

- David Faure


On Dec. 4, 2016, 12:33 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129613/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2016, 12:33 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kwallet
> 
> 
> Description
> -------
> 
> GpgME-1.7.0 released > 2 months ago, KF5Gpgmepp no longer maintained.
> No reason to keep the fallback any longer.
> 
> Separate commits:
> - This reverts commit 60ebcad53c95ecfbe822647075f79578c3420851.
> - Specify minimum required GpgME++ version 1.7.0
> - Drop obsolete FindGpgme.cmake
> - Messages: More QGpgME -> GpgME
> 
> 
> Diffs
> -----
> 
>   cmake/FindGpgme.cmake 7a092104ba0604b0606c4662750b8b32c5c3e2c6 
>   src/runtime/kwalletd/CMakeLists.txt fe72f2ef50417010a9c49b9b6dfdf6465c2e23fb 
>   src/runtime/kwalletd/backend/CMakeLists.txt 0bd312688b2cdc49be14ffe278068309ac06051c 
>   src/runtime/kwalletd/knewwalletdialog.cpp 7383b1310733c208ca269bb8c1c407cb87291c13 
>   src/runtime/kwalletd/kwalletwizard.cpp 582b5e9b0e2d625e5219fc2ac48d0dd1690448ae 
>   tests/kwalletd/CMakeLists.txt 1e7c4b77ba478147fae964f61c28a736e32b9ea9 
> 
> Diff: https://git.reviewboard.kde.org/r/129613/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161214/547d9654/attachment.html>


More information about the Kde-frameworks-devel mailing list