Review Request 129643: DesktopFileParser: Honor ServiceTypes field

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129643/
-----------------------------------------------------------

(Updated Dec. 13, 2016, 2:20 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 49bc26a135bf92bcddecabfdd4f3f71f65540104 by Aleix Pol to branch master.


Repository: kcoreaddons


Description
-------

In case there's a ServiceType field in the desktop file, look them up for definitions.

Otherwise we just printed a warning whenever the cmake macro was used that nobody resolved (see plasma workspace).

This patch assumes some heuristic for the naming that is not standardized (`/` to `-`, all lower-case), it won't enforce it though, so worst case scenario it works just as it does now.


Diffs
-----

  KF5CoreAddonsMacros.cmake eff0e3f 
  autotests/desktoptojsontest.cpp bb539ee 
  src/lib/plugin/desktopfileparser.cpp 2eb198d 
  src/lib/plugin/desktopfileparser_p.h c61b297 

Diff: https://git.reviewboard.kde.org/r/129643/diff/


Testing
-------

Tests still pass, plasma-workspace applets are generated with correct types.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161213/67926946/attachment-0001.html>