Review Request 129554: RFC: Add KNS support for KPackage

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129554/#review101409
-----------------------------------------------------------


Ship it!




while is true that just having an id is not a good way to uniquely and semantically identify an asset, I don't thinnk it's realistic to have all the content on kdelook identified by a reverse domain url

- Marco Martin


On Nov. 24, 2016, 4:05 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129554/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2016, 4:05 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> Installs the handlers that should be responsible for installing the dependencies.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e97e698 
>   src/kpackage-install-handlers/CMakeLists.txt ad2f176 
>   src/kpackage-install-handlers/kns/CMakeLists.txt PRE-CREATION 
>   src/kpackage-install-handlers/kns/main.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129554/diff/
> 
> 
> Testing
> -------
> 
> Works, ids are not entirely unique just yet (just within the provider)
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161213/604425c7/attachment.html>