Review Request 129587: Set parent for actions in DropJob's popup menu

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129587/#review101396
-----------------------------------------------------------


Ship it!




Ship It!

- David Faure


On Nov. 29, 2016, 5:56 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129587/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2016, 5:56 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> KAbstractFileItemActionPlugin::actions() has a `parentWidget` argument that plugins can use as parent for the actions. DndPopupMenuPlugin::setup() doesn't have a similar argument, so there can be memory leaks. This patch sets the popup menu as parent so that plugins don't have to care about this.
> 
> The alternative is to deprecate the current setup() method in favor of a new one (maybe called actions() for consistency?) which also takes an additional `QWidget*` as argument.
> 
> 
> Diffs
> -----
> 
>   src/widgets/dndpopupmenuplugin.h 264fbdf42c410d39561ddaca62e4eef9777aba85 
>   src/widgets/dropjob.cpp 1febd3397ec8e993a9786547da9c381a0f57a1f8 
> 
> Diff: https://git.reviewboard.kde.org/r/129587/diff/
> 
> 
> Testing
> -------
> 
> Ensured the actions are actually deleted by connecting a lambda to their `destroyed` signals.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161212/91fa2759/attachment.html>