Review Request 127635: use QSettings::IniFormat

[René J.V. Bertin]

> On April 17, 2016, 12:49 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> > Just briefly looking around at what's using Sonnet, at least Calligra and Quassel uses it on Windows, so I'd really like to migrate the settings on Windows.
> 
> Martin Tobias Holmedahl Sandsmark wrote:
>     it should ideally have a unit test as well, but considering that this would be something temporary it's not a dealbreaker.
>     
>     (I also saw that Otter Browser uses it, which I guess is pretty popular on Windows.)
> 
> René J.V. Bertin wrote:
>     As I said, I have nothing against adding a migration path, but I'd want some pointers on how to implement that. And also know if we really don't need to support both formats during a transition period. 
>     To repeat what I said on the ML: with a packaging approach in which each installed application tends to come with its own copies of all required dependencies, one cannot assume that all those applications automagically get to use a Sonnet library that uses the new format and has an importer for the old format (ditto for the other frameworks that'll need to be patched).
>     That almost calls for an approach that detects presence of settings in the old format, imports those if they're newer than those in the new format store, and also keeps that old format store up to date when saving. IOW, apps using the new Sonnet library would need to pick up settings changes made by apps still using an older version, and vice versa.
>     
>     If that's over the top then I'd say it's almost better not to do any migration at all, because that at least will send a clear message to users. "New version of app didn't pick up certain settings, so I best not expect that any changes I make in that app will be seen from other apps".
> 
> Martin Tobias Holmedahl Sandsmark wrote:
>     I imagine something like this: http://ix.io/wVw
>     
>     But it needs testing from someone who has Windows. I'm not sure if the .ini file is shared amongst all applications for a single user.
> 
> René J.V. Bertin wrote:
>     Yeah, that looks like it would work, but it should be done like that only if the settings are application-specific (I had not considered they might be).
>     
>     I don't really like the idea to include such a change in my patch as I won't be able to test it (apart from checking if it builds when I remove the #ifdefs).
> 
> René J.V. Bertin wrote:
>     What's to stop Sonnet from using a settings category per application, or else a subdirectory per application?
> 
> Martin Tobias Holmedahl Sandsmark wrote:
>     Nothing, really, but there needs to be global defaults as well.
>     
>     As for the bump, it still needs to migrate the settings on Windows, as well as testing on Windows.

Sadly I still cannot test on MS Windows, and that's not likely to change.


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127635/#review94659
-----------------------------------------------------------


On Nov. 20, 2016, 8:44 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127635/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2016, 8:44 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: sonnet
> 
> 
> Description
> -------
> 
> As discussed on kde-frameworks-devel, this is a proposal to use QSettingsIniFormat in order to have the same file format across platforms and avoid storing settings in the registry under MS Windows.
> 
> The ML discussion has touched on the idea of backward compatibility (at least migrating settings from the NativeFormat where this is different from IniFormat). The current patch doesn't yet include anything like that.
> 
> 
> Diffs
> -----
> 
>   autotests/test_settings.cpp f2bc80c 
>   src/core/settings.cpp 8614e35 
>   src/plugins/hspell/hspelldict.cpp b9265eb 
> 
> Diff: https://git.reviewboard.kde.org/r/127635/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.9.5 and Linux (KUbuntu 14.04) with Qt 5.6.0 and FWs 5.20.0 installed into /opt/local .
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161211/d55ff505/attachment-0001.html>