Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

Anthony Fieroni bvbfan at abv.bg
Sat Dec 10 04:30:51 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129394/#review101350
-----------------------------------------------------------



David, this patch has many disadvantages:
1. Search view does not contain paths anymore
2. It cannot open file from it
3. Search view rejects completely all actions

- Anthony Fieroni


On Дек. 5, 2016, 10:04 след обяд, Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129394/
> -----------------------------------------------------------
> 
> (Updated Дек. 5, 2016, 10:04 след обяд)
> 
> 
> Review request for KDE Frameworks, Anthony Fieroni, David Faure, and Emmanuel Pescosta.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> Bug is introduced in https://git.reviewboard.kde.org/r/129297/
> When is fixed new kio-extras realease is needed for 16.08 branch.
> 
> 
> Diffs
> -----
> 
>   filenamesearch/CMakeLists.txt 774d79e 
>   filenamesearch/filenamesearchdbusinterface.h PRE-CREATION 
>   filenamesearch/filenamesearchdbusinterface.cpp PRE-CREATION 
>   filenamesearch/kded/CMakeLists.txt 48160ed 
>   filenamesearch/kded/filenamesearchdbusadaptor.h PRE-CREATION 
>   filenamesearch/kded/filenamesearchdbusadaptor.cpp PRE-CREATION 
>   filenamesearch/kded/filenamesearchmodule.h 4fa6bb1 
>   filenamesearch/kded/filenamesearchmodule.cpp f12626d 
>   filenamesearch/kio_filenamesearch.h 0920394 
>   filenamesearch/kio_filenamesearch.cpp f124f02 
> 
> Diff: https://git.reviewboard.kde.org/r/129394/diff/
> 
> 
> Testing
> -------
> 
> No big ram usage but still not works as expected.
> 1. Perform search in Dolphin
> 2. Delete one result item
> 3. View must be update, but it's not
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161210/d2f80466/attachment.html>


More information about the Kde-frameworks-devel mailing list