Review Request 129628: knewstuff - install missing headers

José Manuel Santamaría Lema panfaust at gmail.com
Fri Dec 9 01:28:52 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129628/
-----------------------------------------------------------

Review request for KDE Frameworks and Dan Leinir Turthra Jensen.


Repository: knewstuff


Description
-------

This patch installs a couple of missing headers:

* knewstuffcore_export.h - which is #include'd from many files in /include/KF5/KNewStuff3/knscore/
* entry.h - this is #include'd from /usr/include/KF5/KNewStuff3/knscore/entryinternal.h as "../entry.h"

If the "entry.h" part of the patch is fine, maybe this commit should be reverted:
https://cgit.kde.org/knewstuff.git/commit/?id=7a644d7147edb816b69fa973630cea6aa72bc3ef


Diffs
-----

  src/CMakeLists.txt 79ef39b 
  src/core/CMakeLists.txt c2a1a24 

Diff: https://git.reviewboard.kde.org/r/129628/diff/


Testing
-------

I just ran a test from the kubuntu package meant to check that all the needed headers are available.


Thanks,

José Manuel  Santamaría Lema

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161209/056e658d/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list