Review Request 129607: Display Application version in About dialog header

[Martin Klapetek]

> On Dec. 3, 2016, 5:48 p.m., Martin Klapetek wrote:
> > How about "Using" for the title of the tab and then removing the "Using" label from inside the tab?
> > 
> > Also, +1 to putting the version front.
> 
> Thomas Pfeiffer wrote:
>     Hm, "Using" sounds a bit weird without context, but "Libraries" or maybe "Libraries used" makes sense to me. The only thing that would not really fit from a purely technical perspective is the windowing system used (though that does not fit in "Version" either because it does not say anything about its version), but I don't think that is a problem.

"Running with" / "Running on" are some other ideas. In any case, I think the "Using" label should now go as its purpose would be now covered by the tab title.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129607/#review101247
-----------------------------------------------------------


On Dec. 3, 2016, 2:39 p.m., Jean-Baptiste Mardelle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129607/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2016, 2:39 p.m.)
> 
> 
> Review request for KDE Frameworks, KDE Usability and Sebastian Kügler.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> -------
> 
> Last year, a change in kaboutapplicationdialog (review 124133) moved the application version in a separate tab. However for applications, it is really annoying (several Kdenlive users complained and I fully agree) to not have this information clearly displayed as soon as the About dialog is displayed. I understand the interest of having a separate version tab displaying the various underlying libraries used, but I propose to display again the application version in the About dialog header (see screenshot).
> 
> 
> Diffs
> -----
> 
>   src/kaboutapplicationdialog.cpp 156410e 
> 
> Diff: https://git.reviewboard.kde.org/r/129607/diff/
> 
> 
> Testing
> -------
> 
> Reverts a recent change, tested and works.
> 
> 
> File Attachments
> ----------------
> 
> About dialog with version
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/c02f4767-2a74-4c25-8599-de410678867e__about.png
> Updated patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/ee13cb47-2162-4be7-8255-3dce7f470c2b__about2.png
> 
> 
> Thanks,
> 
> Jean-Baptiste Mardelle
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161205/a2ad0582/attachment-0001.html>