Review Request 129540: DropJob: emit started copy job after creation

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129540/#review101295
-----------------------------------------------------------



Missing: QSignalSpy in dropjobtest to double-check that the new signal is emitted when it should.


src/widgets/dropjob.h (line 73)
<https://git.reviewboard.kde.org/r/129540/#comment67849>

    I suggest adding these sentences to the documentation:
    
    "You can use @p job to monitor the progress of the copy/move/link operation."
    
    "Note that a CopyJob isn't always started by DropJob. For instance dropping files onto an executable will simply launch the executable."
    
    "@since 5.30"


- David Faure


On Dec. 4, 2016, 7:22 p.m., Alex Bikadorov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129540/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2016, 7:22 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> For giving an application a chance to monitor and control the subjob.
> 
> 
> Diffs
> -----
> 
>   src/widgets/dropjob.h 5c9bf10ecc34282d9acb50cef93e7bc8665cb904 
>   src/widgets/dropjob.cpp 1febd3397ec8e993a9786547da9c381a0f57a1f8 
> 
> Diff: https://git.reviewboard.kde.org/r/129540/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Bikadorov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161205/5c7aada9/attachment.html>