Review Request 129611: Make Gpgme a required dependency if we build Gpgme interface.

[Andreas Sturmlechner]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129611/#review101269
-----------------------------------------------------------



Is it really a possible scenario that Gpgmepp is installed, but not Gpgme? In the past, that call was necessary to fix build with gpgme not being in a subdir below /usr/include, but not anymore. I guess there would be a way to get rid of gpgme.h instead.

- Andreas Sturmlechner


On Dec. 4, 2016, 12:49 a.m., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129611/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2016, 12:49 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwallet
> 
> 
> Description
> -------
> 
> Acording to the README of QGpgME, we cannot expect to be gpgme.h be available, so we need to search for GpgME by our own.
> 
> See https://git.gnupg.org/cgi-bin/gitweb.cgi?p=gpgme.git;a=blob;f=lang/cpp/README;h=b9a48da15ce424a08d0e8c5d20846af8882da193;hb=HEAD#l31
> 
>   31 7. Complete abstraction of the C-API so "gpgme.h" should not
>   32    be needed in your project using GpgME++.
> 
> 
> Diffs
> -----
> 
>   src/runtime/kwalletd/CMakeLists.txt 5092a7e77a1ca7203827e444c11310566b2cc8b5 
> 
> Diff: https://git.reviewboard.kde.org/r/129611/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161204/722da3d8/attachment.html>