Review Request 129607: Display Application version in About dialog header

[Martin Gräßlin]

> On Dec. 3, 2016, 2:29 p.m., Sebastian Kügler wrote:
> > I understand the problem, but I don't like the duplication you're introducing with this patch: The version number is now on the screen two times when you open the versions tab, and also, why have a versions tab, when the version is already displayed.
> 
> Luigi Toscano wrote:
>     Change "Version" tab to "Environment"?
>     Merge Version into the main info tab (even if I have the feeling that this we discussed)?
> 
> Martin Gräßlin wrote:
>     I don't like the name "Environment". I would expect the env variables there
> 
> Luigi Toscano wrote:
>     Sure, there are other options. "System details"? "Libraries" (and we could put the poppler version for Okular, for example)? ...

> and we could put the poppler version for Okular

yeah, that was one of the ideas for having an API to adjust the version information.

I don't have a good idea for the name of the tab.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129607/#review101235
-----------------------------------------------------------


On Dec. 3, 2016, 2:39 p.m., Jean-Baptiste Mardelle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129607/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2016, 2:39 p.m.)
> 
> 
> Review request for KDE Frameworks, KDE Usability and Sebastian Kügler.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> -------
> 
> Last year, a change in kaboutapplicationdialog (review 124133) moved the application version in a separate tab. However for applications, it is really annoying (several Kdenlive users complained and I fully agree) to not have this information clearly displayed as soon as the About dialog is displayed. I understand the interest of having a separate version tab displaying the various underlying libraries used, but I propose to display again the application version in the About dialog header (see screenshot).
> 
> 
> Diffs
> -----
> 
>   src/kaboutapplicationdialog.cpp 156410e 
> 
> Diff: https://git.reviewboard.kde.org/r/129607/diff/
> 
> 
> Testing
> -------
> 
> Reverts a recent change, tested and works.
> 
> 
> File Attachments
> ----------------
> 
> About dialog with version
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/c02f4767-2a74-4c25-8599-de410678867e__about.png
> Updated patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/ee13cb47-2162-4be7-8255-3dce7f470c2b__about2.png
> 
> 
> Thanks,
> 
> Jean-Baptiste Mardelle
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161203/22b1bb31/attachment.html>