Review Request 129607: Display Application version in About dialog header

[Elvis Angelaccio]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129607/#review101228
-----------------------------------------------------------



+1, I also find the additional click annoying.

Though with this change I'm not sure it makes sense to keep the "Version" tab as it currently is. We would have duplicate information in there. Maybe we could rename it to "Libraries" or "System" and remove the version number of the application?

- Elvis Angelaccio


On Dec. 3, 2016, 11:55 a.m., Jean-Baptiste Mardelle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129607/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2016, 11:55 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> -------
> 
> Last year, a change in kaboutapplicationdialog (review 124133) moved the application version in a separate tab. However for applications, it is really annoying (several Kdenlive users complained and I fully agree) to not have this information clearly displayed as soon as the About dialog is displayed. I understand the interest of having a separate version tab displaying the various underlying libraries used, but I propose to display again the application version in the About dialog header (see screenshot).
> 
> 
> Diffs
> -----
> 
>   src/kaboutapplicationdialog.cpp 156410e 
> 
> Diff: https://git.reviewboard.kde.org/r/129607/diff/
> 
> 
> Testing
> -------
> 
> Reverts a recent change, tested and works.
> 
> 
> File Attachments
> ----------------
> 
> About dialog with version
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/c02f4767-2a74-4c25-8599-de410678867e__about.png
> 
> 
> Thanks,
> 
> Jean-Baptiste Mardelle
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161203/8b56b2ec/attachment.html>