Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

[Albert Astals Cid]

> On Dec. 1, 2016, 9:43 p.m., Albert Astals Cid wrote:
> > src/kstatusnotifieritem.cpp, line 972
> > <https://git.reviewboard.kde.org/r/127216/diff/7/?file=485236#file485236line972>
> >
> >     maybe move this to the else?
> 
> Anthony Fieroni wrote:
>     NET::WMFrameExtents is not needed anymore.
> 
> Anthony Fieroni wrote:
>     info is used on 977 and 984 is two 'else' braches :)

Right, i missed one.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127216/#review101203
-----------------------------------------------------------


On Nov. 13, 2016, 5:17 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127216/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2016, 5:17 a.m.)
> 
> 
> Review request for KDE Frameworks, Martin Gräßlin and Martin Klapetek.
> 
> 
> Bugs: 356523
>     https://bugs.kde.org/show_bug.cgi?id=356523
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> Store position of widget before hide it
> 
> 
> Diffs
> -----
> 
>   src/kstatusnotifieritem.cpp 3eb39b2 
>   src/kstatusnotifieritemprivate_p.h 8fdfd4c 
> 
> Diff: https://git.reviewboard.kde.org/r/127216/diff/
> 
> 
> Testing
> -------
> 
> Tested on pixel ratio = 1 with Amarok, Kmail, Akregator, Kalarm, Ktimer
> Close with 'X' - restore in correct pos
> Hide by click at icon in systray - restore correct pos
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161202/c5667a12/attachment.html>