[Differential] [Requested Changes To] D2075: Fix bug in kfiledialog.cpp that causes crashing when native widgets are used.
kfunk (Kevin Funk)
noreply at phabricator.kde.org
Fri Dec 2 11:12:56 UTC 2016
kfunk requested changes to this revision.
kfunk added a reviewer: kfunk.
kfunk added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kfiledialog.cpp:607
> + if (d->native) {
> + return;
> + }
Should we rather check for `!d->w` here and below? Would make more sense IMO.
REPOSITORY
R239 KDELibs4Support
REVISION DETAIL
https://phabricator.kde.org/D2075
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: jonathans, #frameworks, dfaure, kfunk
Cc: kfunk, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161202/6bb7c168/attachment.html>
More information about the Kde-frameworks-devel
mailing list