Review Request 128792: Fix choose other icon

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128792/#review98764
-----------------------------------------------------------




src/kicondialog.cpp (line 611)
<https://git.reviewboard.kde.org/r/128792/#comment66503>

    please extract this code into a free standing function and then call it here:
    
        dlg->setModal(isAncestorModal(q->parentWidget()));


- Milian Wolff


On Aug. 29, 2016, 1:07 a.m., Tomaz  Canabrava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128792/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2016, 1:07 a.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> -------
> 
> When running KDevelop I wanted to choose the icon for a
> folder in the file picker dialog, but the file picker disappeared
> and I couldn't find it anywhere.
> 
> Tested the same thing on dolphin, same thing happened.
> 
> This patch makes sure that if one of the widgets are modal, the
> this will run on top of it as modal too.
> 
> Signed-off-by: Tomaz Canabrava <tomaz.canabrava at gmail.com>
> 
> 
> Diffs
> -----
> 
>   src/kicondialog.cpp d75ad970504bff5ae1cb785e6a06f9f9da58a1ff 
> 
> Diff: https://git.reviewboard.kde.org/r/128792/diff/
> 
> 
> Testing
> -------
> 
> now the dialog to choose the other icon appears.
> 
> 
> Thanks,
> 
> Tomaz  Canabrava
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160829/47ca5d17/attachment.html>