Review Request 128790: Call utempter manually

[Martin Tobias Holmedahl Sandsmark]

> On Aug. 28, 2016, 3:24 p.m., Oswald Buddenhagen wrote:
> > src/kpty.cpp, line 165
> > <https://git.reviewboard.kde.org/r/128790/diff/2/?file=475587#file475587line165>
> >
> >     hmpf, i'd really prefer this to be a configure/cmake thing rather than a runtime detection. less runtime code, and allows for a user override (without reading yet another custom env variable, which sounds really off).
> 
> Martin Tobias Holmedahl Sandsmark wrote:
>     you mean make cmake do the whole figure-out-where-the-executable-is thing? because that's beyond my abilities to do. and it doesn't really require yet another environment variable, just normal $PATH tweaking afaics.
> 
> Oswald Buddenhagen wrote:
>     yes, i do.
>     learn it (it's really not hard, and the kde sources are full of relevant examples), or ask someone to help (it won't be me).
>     
>     extending PATH with libexec stuff is just wrong. also, this is plainly not something anyone should need to bother with after the build, as it's a static adjustment, just like linking libutempter.

> extending PATH with libexec stuff is just wrong

I read wrong, QStandardPaths::findExecutable() doesn't look in $PATH if we pass it a list of paths to look in.


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128790/#review98749
-----------------------------------------------------------


On Aug. 28, 2016, 5:36 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128790/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2016, 5:36 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure, Kurt Hindenburg, Rex Dieter, and Thiago Macieira.
> 
> 
> Bugs: 364779
>     https://bugs.kde.org/show_bug.cgi?id=364779
> 
> 
> Repository: kpty
> 
> 
> Description
> -------
> 
> According to the investigation in https://bugs.kde.org/show_bug.cgi?id=364779 utempter does stuff in a way that isn't compatible with QProcess/KProcess/KPtyProcess (calling sigaction() before launching its child process).
> 
> So instead we invoke it manually with QProcess.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt caab96f 
>   src/kpty.cpp 15c3b81 
>   src/kpty_p.h 192bf1c 
> 
> Diff: https://git.reviewboard.kde.org/r/128790/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160828/6dec393b/attachment.html>