Review Request 128790: Call utempter manually

[Oswald Buddenhagen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128790/#review98749
-----------------------------------------------------------




src/kpty.cpp (line 165)
<https://git.reviewboard.kde.org/r/128790/#comment66494>

    hmpf, i'd really prefer this to be a configure/cmake thing rather than a runtime detection. less runtime code, and allows for a user override (without reading yet another custom env variable, which sounds really off).



src/kpty.cpp (line 528)
<https://git.reviewboard.kde.org/r/128790/#comment66495>

    please add a comment noting that you're reproducing libutempter x.y behavior on platform foo. just in case there are still incompatible versions around.


- Oswald Buddenhagen


On Aug. 28, 2016, 2:58 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128790/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2016, 2:58 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure, Kurt Hindenburg, Rex Dieter, and Thiago Macieira.
> 
> 
> Bugs: 364779
>     https://bugs.kde.org/show_bug.cgi?id=364779
> 
> 
> Repository: kpty
> 
> 
> Description
> -------
> 
> According to the investigation in https://bugs.kde.org/show_bug.cgi?id=364779 utempter does stuff in a way that isn't compatible with QProcess/KProcess/KPtyProcess (calling sigaction() before launching its child process).
> 
> So instead we invoke it manually with QProcess.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt caab96f 
>   src/kpty.cpp 15c3b81 
>   src/kpty_p.h 192bf1c 
> 
> Diff: https://git.reviewboard.kde.org/r/128790/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160828/90d54378/attachment.html>