Review Request 128790: Remove usage of utempter
Martin Tobias Holmedahl Sandsmark
martin.sandsmark at kde.org
Sun Aug 28 13:13:09 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128790/
-----------------------------------------------------------
Review request for KDE Frameworks, David Faure, Kurt Hindenburg, Rex Dieter, and Thiago Macieira.
Bugs: 364779
https://bugs.kde.org/show_bug.cgi?id=364779
Repository: kpty
Description
-------
According to the investigation in https://bugs.kde.org/show_bug.cgi?id=364779 utempter does stuff in a way that isn't compatible with QProcess/KProcess/KPtyProcess (calling sigaction() before launching its child process). So remove it, and rely on the fallback methods already implemented.
Diffs
-----
CMakeLists.txt 3e17cac
KF5PtyConfig.cmake.in 66f8c43
cmake/FindUTEMPTER.cmake a3ea06a
src/CMakeLists.txt caab96f
src/ConfigureChecks.cmake ded08f4
src/config-pty.h.cmake aaaf8d9
src/kpty.cpp 15c3b81
Diff: https://git.reviewboard.kde.org/r/128790/diff/
Testing
-------
Thanks,
Martin Tobias Holmedahl Sandsmark
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160828/3c4c6994/attachment.html>
More information about the Kde-frameworks-devel
mailing list