Review Request 128773: Revert "Don't use QQuickWidget::quickWindow() as it was added in Qt 5.5"

David Edmundson david at davidedmundson.co.uk
Sat Aug 27 20:01:44 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128773/#review98728
-----------------------------------------------------------


Fix it, then Ship it!





src/kcmoduleqml.cpp (line 114)
<https://git.reviewboard.kde.org/r/128773/#comment66489>

    Then you don't need this either.


- David Edmundson


On Aug. 26, 2016, 5 p.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128773/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2016, 5 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcmutils
> 
> 
> Description
> -------
> 
> This reverts commit 5432c3edf5e074f1e951e6ecc682f7a400e2818f.
> 
> kcmutils now depends on Qt 5.5 so it should be fine to go in.
> 
> 
> Diffs
> -----
> 
>   src/kcmoduleqml.cpp 1165c61 
> 
> Diff: https://git.reviewboard.kde.org/r/128773/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160827/11566733/attachment.html>


More information about the Kde-frameworks-devel mailing list