Review Request 128759: Show shortcut for New Folder action

[Anthony Fieroni]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128759/#review98652
-----------------------------------------------------------




src/filewidgets/knewfilemenu.cpp (line 671)
<https://git.reviewboard.kde.org/r/128759/#comment66450>

    I have a stupid question, but where (i can't see) action is added to collection i.e. case when act != nullptr


- Anthony Fieroni


On Авг. 25, 2016, 7:57 след обяд, Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128759/
> -----------------------------------------------------------
> 
> (Updated Авг. 25, 2016, 7:57 след обяд)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 366075
>     https://bugs.kde.org/show_bug.cgi?id=366075
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Dolphin sets a F10 shortcut to create new folders, but this shortcut doesn't show up near the action. This happens because the action is created by KNewFileMenu which doesn't know about the shortcut. Since we pass an action collection to KNewFileMenu, this issue can be easily fixed by looking up a fixed action key (e.g. `create_dir`, already used by Dolphin) and assuming that the client code sets a shortcut for this action.
> 
> We just need to keep track whether we find such an action in the action collection (otherwise "New -> Folder..." in Dolphin opens the dialog twice).
> 
> 
> Diffs
> -----
> 
>   src/filewidgets/knewfilemenu.h dfc808b9072c118031d2ed675a6578e192f7abf6 
>   src/filewidgets/knewfilemenu.cpp a340429f5b7f99842747c6805187256e00179f22 
> 
> Diff: https://git.reviewboard.kde.org/r/128759/diff/
> 
> 
> Testing
> -------
> 
> Make sure that "New -> Folder" shows F10 as shortcut in Dolphin.
> Make sure that triggering the action doesn't show the dialog twice.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160825/ad901769/attachment.html>