Review Request 128232: The default level for logging categories should be Info rather than Warning.

[David Edmundson]

> On July 14, 2016, 1:11 p.m., David Edmundson wrote:
> > modules/ECMQtDeclareLoggingCategory.cmake, line 72
> > <https://git.reviewboard.kde.org/r/128232/diff/1/?file=469178#file469178line72>
> >
> >     This is new in Qt5.5
> >     
> >     It seems frameworks currently still tries to build against Qt5.4
> >     
> >     Either this needs some additional switching or we bump requirements.

This comment is no longer true. Ship it!


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128232/#review97401
-----------------------------------------------------------


On July 13, 2016, 10:22 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128232/
> -----------------------------------------------------------
> 
> (Updated July 13, 2016, 10:22 p.m.)
> 
> 
> Review request for Extra Cmake Modules, KDE Frameworks and David Edmundson.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> The whole point of Info is to be used by apps who want to print out some
> info for the user, not disabled by default.
> 
> Example use case: ksmserver could output the name of the autostart
> files it's starting, so user can check their own scripts are started,
> and associate any errors with the corresponding script.
> 
> In other words:
> Debug = debugging for the developer
> Info = debugging for the user :-)
> 
> This commit shows the benefit of having a central place for changing this
> (many category definitions do not use this macro though)
> 
> 
> Diffs
> -----
> 
>   modules/ECMQtDeclareLoggingCategory.cmake c125949a46c4b83544413f23d5e04b2d8ea2c4cf 
> 
> Diff: https://git.reviewboard.kde.org/r/128232/diff/
> 
> 
> Testing
> -------
> 
> The autotests still pass -- somewhat to my surprise ;-)
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160825/e7f74baf/attachment.html>