Review Request 128740: uncompress archives in subfolders

Jeremy Whiting jpwhiting at kde.org
Tue Aug 23 15:26:58 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128740/#review98570
-----------------------------------------------------------


Ship it!




Ship It!

- Jeremy Whiting


On Aug. 23, 2016, 8:43 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128740/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2016, 8:43 a.m.)
> 
> 
> Review request for KDE Frameworks, Sebastian Kügler and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> -------
> 
> if the archive downloaded by ghns has more than a file inside (either single file or a folder at the root), uncompress it in a folder called the same as the file name (without path or extension)
> 
> this fixes downloading and installing plasma wallpaper packages (those that provide multiple resolutions).
> I don't know if this behavior would in turn break other applications, but i don't think so as it seems the behavior changed between kde4 and kf5.
> if needed i can make it do this only in the case of wallpapers (if (standardResourceDirectory == QLatin1String("wallpaper"))) but i think this should be the correct behavior
> 
> 
> Diffs
> -----
> 
>   src/core/installation.cpp a027418 
> 
> Diff: https://git.reviewboard.kde.org/r/128740/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160823/f77aaf7d/attachment.html>


More information about the Kde-frameworks-devel mailing list