Review Request 128739: Fix build with Qt < 5.6

Heiko Becker heirecka at exherbo.org
Tue Aug 23 11:28:44 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128739/
-----------------------------------------------------------

(Updated Aug. 23, 2016, 11:28 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.


Changes
-------

Submitted with commit b241c854c42931280ee5366439af40144f1268af by Heiko Becker to branch master.


Repository: sonnet


Description
-------

Also correct the other #ifdef because like QChar::Script_SignWriting
0e1f3aab11a4310595d8651c02ce5f9d60c93252 in qtbase.git introduced the
other enums as well. That commit was first released with Qt 5.6

BUG: 366789
CCMAIL: martin.sandsmark at kde.org


Diffs
-----

  src/core/guesslanguage.cpp 5c5239fbe99c9a3ea95bd07dc4d0ec6582897379 

Diff: https://git.reviewboard.kde.org/r/128739/diff/


Testing
-------

Haven't an old Qt around, tested building with 5.7. though.


Thanks,

Heiko Becker

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160823/aa4d7cb8/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list