Review Request 128730: kdeclarative: fix crash in IconDialog when no QApplication is available.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128730/
-----------------------------------------------------------

(Updated Aug. 22, 2016, 9:14 a.m.)


Review request for KDE Frameworks and Marco Martin.


Changes
-------

add missing "new KIconDialog" line (oops!)


Repository: kdeclarative


Description
-------

This happens when QtCreator launches qmlplugindump.
Testcase: qmlplugindump -nonrelocatable org.kde.plasma.calendar 2.0 /usr/lib64/qml

There are more similar issues, e.g. in
plasma-framework/src/declarativeimports/plasmacomponents/qmenu.cpp


Diffs (updated)
-----

  src/qmlcontrols/kquickcontrolsaddons/icondialog.cpp 4fc7dcc99c7474b4658150c3622c5685d092e6ad 

Diff: https://git.reviewboard.kde.org/r/128730/diff/


Testing
-------

as mentionned above


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160822/37989c5a/attachment-0001.html>