Review Request 128730: kdeclarative: fix crash in IconDialog when no QApplication is available.

[Kai Uwe Broulik]

> On Aug. 22, 2016, 7:40 vorm., Martin Gräßlin wrote:
> > Is there a way to say that the qml import may only be used if it's a QApplication? I'm not sure whether it makes sense to patch out all places where a QWidget dependency is used. In the end it will be broken in the runtime anyway.

We could register it as uncreatable type if not QApplication, I suppose, but that'll break existing cpde and is pretty non-deterministic from the QML code writer's POV.


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128730/#review98539
-----------------------------------------------------------


On Aug. 21, 2016, 5:36 nachm., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128730/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2016, 5:36 nachm.)
> 
> 
> Review request for KDE Frameworks and Marco Martin.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> This happens when QtCreator launches qmlplugindump.
> Testcase: qmlplugindump -nonrelocatable org.kde.plasma.calendar 2.0 /usr/lib64/qml
> 
> There are more similar issues, e.g. in
> plasma-framework/src/declarativeimports/plasmacomponents/qmenu.cpp
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kquickcontrolsaddons/icondialog.cpp 4fc7dcc99c7474b4658150c3622c5685d092e6ad 
> 
> Diff: https://git.reviewboard.kde.org/r/128730/diff/
> 
> 
> Testing
> -------
> 
> as mentionned above
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160822/2d44cbbe/attachment.html>