Review Request 128661: [KTreeWidgetsSearchLineWidget] Use placeholderText instead of separate label
Kevin Funk
kfunk at kde.org
Sat Aug 20 16:14:44 UTC 2016
> On Aug. 14, 2016, 7:17 p.m., Thomas Pfeiffer wrote:
> > Actually, this is in violation of the current search HIG ( https://community.kde.org/KDE_Visual_Design_Group/HIG/SearchPattern ), but since the de-facto standard in our software and elsewhere is an inline hint, I suppose we should update the HIG.
> >
> > So yes, +1, good change!
One drawback: The search line is no longer acccessible via keyboard mnemonics if it's just an inline hint.
Is this something you're aware of in the VDG team? Any solutions/work-arounds?
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128661/#review98384
-----------------------------------------------------------
On Aug. 12, 2016, 8:22 a.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128661/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2016, 8:22 a.m.)
>
>
> Review request for KDE Frameworks and KDE Usability.
>
>
> Repository: kitemviews
>
>
> Description
> -------
>
> This makes the search look identical to virtually any other search box used throughout the workspace.
>
>
> Diffs
> -----
>
> src/ktreewidgetsearchline.cpp e40a61e
> src/ktreewidgetsearchlinewidget.cpp 9af4c2e
>
> Diff: https://git.reviewboard.kde.org/r/128661/diff/
>
>
> Testing
> -------
>
> Tests still pass.
>
> Looks good. I couldn't figure out how to just create the QLineEdit without the intermediate QHBoxLayout.
>
>
> File Attachments
> ----------------
>
> Separate "Search:" label gone
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/12/c1e2e92d-2113-4d9f-9594-a2e1db0545c2__Screenshot_20160812_102022.png
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160820/4baf2710/attachment.html>
More information about the Kde-frameworks-devel
mailing list