Review Request 128709: Remove code that can never be executed.
Marco Martin
notmart at gmail.com
Thu Aug 18 12:04:41 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128709/#review98466
-----------------------------------------------------------
Ship it!
Ship It!
- Marco Martin
On Aug. 18, 2016, 11:55 a.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128709/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2016, 11:55 a.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> We know d->uiReady is false, otherwise we wouldn't be in this code
> block. Modifying d->loadingApplets won't change that.
>
> I don't know what this was possibly trying to do.
>
>
> Diffs
> -----
>
> src/plasma/containment.cpp 31b83927a17cab23e7d70e25dec48f6dbe74699d
>
> Diff: https://git.reviewboard.kde.org/r/128709/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160818/232a9713/attachment.html>
More information about the Kde-frameworks-devel
mailing list