Review Request 128660: Add an optional reveal password button to TextField

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128660/
-----------------------------------------------------------

(Updated Aug. 14, 2016, 10:48 p.m.)


Review request for KDE Frameworks and Plasma.


Changes
-------

Did Kai's comments.

This patch also fixes:

    margins being re-evaluated on property changes
    RTL icons
    Actual use of the style in QQC without use of PlasmaComponents


Repository: plasma-framework


Description
-------

Similar to KPasswordWidget in kwidgetaddons


Diffs (updated)
-----

  src/declarativeimports/plasmacomponents/qml/TextField.qml c0d9155df5bb584cd3070a66c99d98465b81a5ef 
  src/declarativeimports/plasmastyle/TextFieldStyle.qml 05ff3d542ad0de6879ec1de832b5e5d9ed33281e 
  tests/components/textfield.qml 0a7f8886ba0552c2bb23424ee873423cc5ee0585 

Diff: https://git.reviewboard.kde.org/r/128660/diff/


Testing
-------

Updated manual test. See screenshot.


File Attachments
----------------

Spectacle.B12253.png
  https://git.reviewboard.kde.org/media/uploaded/files/2016/08/12/b308072d-a1c2-4bd8-9405-2826fc9f4086__Spectacle.B12253.png


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160814/b6c2e9cc/attachment-0001.html>