Review Request 126894: Refactor the listjobtest to allow listing of multile paths.
David Faure
faure at kde.org
Sat Aug 13 08:05:07 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126894/#review98344
-----------------------------------------------------------
Ship it!
Ship It!
- David Faure
On Jan. 26, 2016, 3:34 p.m., Milian Wolff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126894/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 3:34 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Repository: kio
>
>
> Description
> -------
>
> With this change it is now possible to list multiple paths
> as defined via the command line.
>
> While at it, I refactored the code to clean it up:
>
> - rely on QEventLoopLocker to quit the application once all jobs
> have finished
> - use a lambda to count the listed entries
> - don't append to a KIO::UDSEntryList to cound the listed entries
>
>
> Diffs
> -----
>
> tests/listjobtest.cpp 702b09950734894a9f82746d58071225419b4e3f
>
> Diff: https://git.reviewboard.kde.org/r/126894/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Milian Wolff
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160813/80dfbe02/attachment.html>
More information about the Kde-frameworks-devel
mailing list