Review Request 128650: [KBookmarks] Fix crash on app shutdown due to QRegExp(QStringLiteral())

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128650/#review98301
-----------------------------------------------------------



Rather port to `QRegularExpression` right away?

- Kevin Funk


On Aug. 10, 2016, 3:21 p.m., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128650/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2016, 3:21 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kbookmarks
> 
> 
> Description
> -------
> 
> Kleopatra was crashing on shutdown during cleanup of global statics with QRegExps. Based on [0] I was able to trace the pointer back to .rodata in libKF5KBookmarks.so. The crash is gone when QRegExp(QLatin1String()) is used.
> 
> 
> [0] https://blogs.kde.org/2015/11/05/qregexp-qstringliteral-crash-exit
> 
> 
> Diffs
> -----
> 
>   src/kbookmarkimporter_ie.cpp 7dcbfb3 
>   src/kbookmarkmanager.cpp dd7a98b 
> 
> Diff: https://git.reviewboard.kde.org/r/128650/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160810/fbe2a5d3/attachment.html>