Review Request 128640: Keep compatiable slot createApplet with Frameworks 5.24 *THIS NEEDS BACKPORTING TO 5.25*

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128640/
-----------------------------------------------------------

(Updated Aug. 10, 2016, 9:37 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, Plasma and David Faure.


Changes
-------

Submitted with commit 1ace6a46dedfb8536890f9c86e7b4fbbc55931ac by David Edmundson to branch master.


Repository: plasma-framework


Description
-------

Commit bb70febdbe397b617e5c41aff5494fdbc185fa88 changed the slot for
adding createApplet, turning the final argument from QPoint to QRect.

If the rectangle size is nothing, it acts like the original code.

Despite this being private API (ish) there is a hacks in plasma-
workspace that call methods on the view via QMetaObject invoke. This
obviously fails. As we need compatibility for Plasma/5.7 and earlier a
compatibility slot needs to stay.


*THIS NEEDS BACKPORTING TO 5.25*


Diffs
-----

  src/scriptengines/qml/plasmoid/containmentinterface.h c058f8358b4aa123749959a3de5b0667d7a1fecc 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp 4efc1e109bbab8ef43b686be25574ed5bd66d9ce 

Diff: https://git.reviewboard.kde.org/r/128640/diff/


Testing
-------

Before: alternatives context menu on the desktop just deleted the applet
Now: works


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160810/76a4faba/attachment-0001.html>