Review Request 128641: Fix argument type in QMetaObject invoke *NEEDS BACKPORTING TO 5.25*

David Edmundson david at davidedmundson.co.uk
Wed Aug 10 09:37:37 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128641/
-----------------------------------------------------------

(Updated Aug. 10, 2016, 9:37 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, Plasma and David Faure.


Changes
-------

Submitted with commit 8031d80df57ce912c99561bcf54c9eb73fb498bb by David Edmundson to branch master.


Repository: plasma-framework


Description
-------

Commit bb70febdbe397b617e5c41aff5494fdbc185fa88 ported an argument from
QPoint to QRectF. However, not all local invocations were updated correctly with one passing a QRect, which fails.

*NEEDS BACKPORTING TO 5.25*


Diffs
-----

  src/scriptengines/qml/plasmoid/containmentinterface.cpp 4efc1e109bbab8ef43b686be25574ed5bd66d9ce 

Diff: https://git.reviewboard.kde.org/r/128641/diff/


Testing
-------

Before: Couldn't drag applet from Widget Explorer to Desktop
After: Can

Checked the other invocations are correct.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160810/ad485507/attachment.html>


More information about the Kde-frameworks-devel mailing list