Review Request 128642: Fix blatant bug in code that was pushed unreviewed

David Edmundson david at davidedmundson.co.uk
Wed Aug 10 09:37:40 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128642/
-----------------------------------------------------------

(Updated Aug. 10, 2016, 9:37 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
-------

Submitted with commit 920dbcb1e85ba76101ab291aeefe17026e57c6e2 by David Edmundson to branch master.


Repository: plasma-framework


Description
-------

commit c8fdd7ed2032b7b0664a6c9d0d56296f674abeb2 pushes a lazy fix for a
crash, but instead just leaves all signals blocked on
ContainmentInterface


Diffs
-----

  src/scriptengines/qml/plasmoid/containmentinterface.cpp 55d91aa9d09ee37ec523f9a16f347586db00ecd5 

Diff: https://git.reviewboard.kde.org/r/128642/diff/


Testing
-------

Read the code.
Which apparently the previous person didn't do.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160810/f48461ec/attachment.html>


More information about the Kde-frameworks-devel mailing list