Review Request 128608: Add Donate entry to KStandardShortcut

Matthew Dawson matthew at mjdsystems.ca
Wed Aug 10 03:24:44 UTC 2016



> On Aug. 9, 2016, 11:23 p.m., Matthew Dawson wrote:
> > LGTM.  I can't speak for the other review.

Sorry, one other thing:  Please make sure to put a CHANGELOG: entry in the commit message.  Thanks!


- Matthew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128608/#review98258
-----------------------------------------------------------


On Aug. 8, 2016, 5:05 a.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128608/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2016, 5:05 a.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> This patch adds a Donate entry, such that https://git.reviewboard.kde.org/r/128609/ builds.
> 
> There is no default shortcut set.
> 
> 
> Diffs
> -----
> 
>   src/gui/kstandardshortcut.h a5a7c28f86094bd346abc8dc17e24a6bd365f5bd 
>   src/gui/kstandardshortcut.cpp 6d749455782d55a81ed5448f35eade954c1df615 
> 
> Diff: https://git.reviewboard.kde.org/r/128608/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160810/08609474/attachment.html>


More information about the Kde-frameworks-devel mailing list